Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Jan 15, 2025

Problem

The output format of clones found in jscpd can be difficult to parse. As an example, see https://github.com/aws/aws-toolkit-vscode/actions/runs/12778633640/job/35621822359?pr=6370. Additionally, it mentions file names and line numbers, but doesn't provide a way to get to those files.

Solution

  • reduce friction by linking directly to the duplicates
    Ex.
image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Hweinstock Hweinstock changed the title build(jscpd): improve output format (WIP) build(jscpd): improve output format Jan 15, 2025
@Hweinstock Hweinstock marked this pull request as ready for review January 15, 2025 16:41
@Hweinstock Hweinstock requested a review from a team as a code owner January 15, 2025 16:41
@justinmk3 justinmk3 merged commit efedd96 into aws:master Jan 15, 2025
25 of 26 checks passed
@Hweinstock Hweinstock deleted the jscpd/formatOutput branch January 15, 2025 17:23
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
The output format of clones found in `jscpd` can be difficult to parse.
As an example, see
https://github.com/aws/aws-toolkit-vscode/actions/runs/12778633640/job/35621822359?pr=6370.
Additionally, it mentions file names and line numbers, but doesn't
provide a way to get to those files.

## Solution
- reduce friction by linking directly to the duplicates
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
## Problem
The output format of clones found in `jscpd` can be difficult to parse.
As an example, see
https://github.com/aws/aws-toolkit-vscode/actions/runs/12778633640/job/35621822359?pr=6370.
Additionally, it mentions file names and line numbers, but doesn't
provide a way to get to those files.

## Solution
- reduce friction by linking directly to the duplicates
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
## Problem
The output format of clones found in `jscpd` can be difficult to parse.
As an example, see
https://github.com/aws/aws-toolkit-vscode/actions/runs/12778633640/job/35621822359?pr=6370.
Additionally, it mentions file names and line numbers, but doesn't
provide a way to get to those files.

## Solution
- reduce friction by linking directly to the duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants